Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tune forge indexer #15393

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

tune forge indexer #15393

wants to merge 2 commits into from

Conversation

rtso
Copy link
Contributor

@rtso rtso commented Nov 25, 2024

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 25, 2024

⏱️ 2h 12m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
forge-indexer / forge 36m 🟥
forge-indexer-sdk / forge 19m 🟥
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 10m
determine-test-metadata 10m 🟩🟩🟩🟩🟩 (+2 more)
rust-cargo-deny 10m 🟩🟩🟩🟩🟩
rust-move-tests 7m
check-dynamic-deps 5m 🟩🟩🟩🟩🟩
rust-move-tests 3m
general-lints 2m 🟩🟩🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
file_change_determinator 59s 🟩🟩🟩🟩🟩
permission-check 14s 🟩🟩🟩🟩🟩
permission-check 13s 🟩🟩🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

rtso commented Nov 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@@ -133,6 +133,8 @@ jobs:
COMMENT_HEADER: forge-indexer
FORGE_TEST_SUITE: indexer_test
FORGE_ENABLE_INDEXER: true
# FORGE_RUNNER_DURATION_SECS: <num_workloads> * <duration_per_workload>
FORGE_RUNNER_DURATION_SECS: 9 * 5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Actions evaluates environment variables as literal strings, so 9 * 5 will be treated as the string "9 * 5" rather than computing to 45. To ensure the duration is set correctly, please replace with FORGE_RUNNER_DURATION_SECS: 45

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant