[multikey] Fix multikey serialization #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnazario
force-pushed
the
fix-multikey
branch
2 times, most recently
from
87838a0
to
f0e1ac8
Compare
gregnazario
force-pushed
the
fix-multikey
branch
from
f0e1ac8
to
4e57122
Compare
GhostWalker562
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a slight difference in implementation, where the bitmap was not being variable length, though it was meant to be variable length.
This fixes it and adds a python generated output as a comparison.
Test Plan
Adds a test for compatibility, along with existing submission tests in examples
Related Links