Add support for AIP-80 parsing and formatting #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnazario
reviewed
Nov 20, 2024
GhostWalker562
force-pushed
the
add-aip80
branch
from
4511561
to
c906687
Compare
GhostWalker562
force-pushed
the
add-aip80
branch
from
c906687
to
672e8fb
Compare
Make ToAIP80 return error, fix bytes parsing
GhostWalker562
force-pushed
the
add-aip80
branch
from
672e8fb
to
181679e
Compare
gregnazario
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for AIP-80 compliant parsing and formatting.
Main Changes
crypto.ParsePrivateKeyandcrypto.FormatPrivateKey.ParsePrivateKeyis responsible for converting hex input (bytes, hexstring, aip80 compliant string) to bytes.FormatPrivateKeyis responsible for taking bytes or hexstring it to an aip80 compliant string.Test Plan
Related Links
https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-80.md