[secp256k1] Add ability to recover public key from signature #108
+182
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnazario
force-pushed
the
add-secp256k1-recovery
branch
from
3d121f0
to
ed18c1e
Compare
2 tasks
gregnazario
force-pushed
the
add-secp256k1-recovery
branch
from
ab67fa9
to
aef2eee
Compare
gregnazario
force-pushed
the
add-secp256k1-recovery
branch
from
aef2eee
to
10b9ea5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ability to recover secp256k1 public key given authentication key and signature. Attempts to find the recovery bit by matching with the authentication key after hashing.
Note: This changes crypto libraries, as the ethereum crypto library didn't give many guarantees or make it easy to accomplish these tasks. Additionally, this new library provides malleability improvements which we needed anyways.
Test Plan
See tests, they test with or without the recovery id.
Related Links