-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdkv2] add indexer query getAccountOwnedTokensByTokenId #29
Conversation
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also need to add the api/internal functions...?
@@ -1,336 +1,96 @@ | |||
import * as Types from "./types"; | |||
import * as Types from './types'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you run fmt or something on this file? not sure why it changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I generally run pnpm fmt
on the whole repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I think it ignores generated
files, not sure why it changed here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm maybe pnpm run indexer-codegen
auto reformats?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh maybe....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, pnpm run indexer-codegen reformats, maybe we just apply autoformat to even generated files (just ignoring lints of course)
oops, good catch. |
Didn't realize this query already been ported over with a different name? I will close this PR - https://github.com/aptos-labs/aptos-ts-sdk/blob/main/src/internal/queries/getAccountOwnedTokensByTokenData.graphql#L2-L11 |
Description
Add getOwnedTokensByTokenData over to sdk v2
Note:
getTokenOwnedFromCollectionNameAndCreatorAddress
is not included, because it relies on getCollectionAddress query, which Oliver is working on.Test Plan
pnpm fmt
pnpm test
pnpm lint
Related Links