Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Add AIP-80 specs #562

Merged
merged 2 commits into from
Nov 1, 2024
Merged

[tests] Add AIP-80 specs #562

merged 2 commits into from
Nov 1, 2024

Conversation

GhostWalker562
Copy link
Contributor

Description

Added specification coverage for AIP-80 private keys. This specification covers:

  • Formatting private keys
  • Deriving private keys from hex strings, bytes, and aip-80 strings
  • Throwing errors when invalid aip-80 strings are provided

Test Plan

  • Tests pass

Related Links

N/A

Checklist

  • Have you ran pnpm fmt?
  • Have you updated the CHANGELOG.md?

@GhostWalker562 GhostWalker562 self-assigned this Oct 30, 2024
@GhostWalker562 GhostWalker562 requested a review from a team as a code owner October 30, 2024 22:39
@GhostWalker562 GhostWalker562 removed their assignment Oct 30, 2024
@GhostWalker562 GhostWalker562 merged commit 65a280e into main Nov 1, 2024
8 checks passed
@GhostWalker562 GhostWalker562 deleted the philip/add-aip80-specs branch November 1, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregnazario gregnazario gregnazario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GhostWalker562 @gregnazario