Refines keyless error handling, handles vkey rotations, updates serialization format of KeylessAccounts #564

heliuchuan · 2024-11-02T00:11:06Z

This further improves handling of Keyless Errors.

KeylessAccount stores a hash of the verifying key used to check rotations.
Handles JWK checking for federated accounts
Updates the serialization format to include the address, and vkey hash. Including address in serialization prevents losing address information if the key has been rotated.

e2e test added. However it is TODO to add a case for vkey rotations, needs the localnet admin key.

GhostWalker562

I like the refactor! A couple of comments but should be good to go.

src/account/AbstractKeylessAccount.ts

src/bcs/serializer.ts

src/core/crypto/keyless.ts

src/bcs/deserializer.ts

hardsetting · 2024-11-16T18:41:54Z

src/bcs/deserializer.ts

@@ -82,6 +82,7 @@ export class Deserializer {
  }

  /**
+   * @deprecated use `deserializeOption` instead.


I don't think this should be marked as deprecated,
deserializeOption returns string | undefined so it's not equivalent

Update

96df9d6

heliuchuan requested a review from a team as a code owner November 2, 2024 00:11

heliuchuan added 4 commits November 1, 2024 20:14

changelog

07b7454

Merge branch 'main' into add-vkey-on-account

b3c0e0e

fix dep cycle

052b6f2

update

0614f85

GhostWalker562 approved these changes Nov 4, 2024

View reviewed changes

update

32a8f3f

heliuchuan merged commit f644e61 into main Nov 5, 2024
8 checks passed

heliuchuan deleted the add-vkey-on-account branch November 5, 2024 01:04

hardsetting reviewed Nov 16, 2024

View reviewed changes

Provide feedback