Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script-composer] Revert script composers #574

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

GhostWalker562
Copy link
Contributor

@GhostWalker562 GhostWalker562 commented Nov 11, 2024

Description

Revert these PRs:
#566
#565

Since they were causing failures in certain environments, specifically NextJS bundling.

Test Plan

  • CI Passes

Related Links

aptos-labs/aptos-wallet-adapter#447
#573

Checklist

  • Have you ran pnpm fmt?
  • Have you updated the CHANGELOG.md?

@GhostWalker562 GhostWalker562 requested a review from a team as a code owner November 11, 2024 23:01
@GhostWalker562 GhostWalker562 merged commit bf8afa1 into main Nov 11, 2024
8 checks passed
@GhostWalker562 GhostWalker562 deleted the revert-script-composer branch November 11, 2024 23:09
@GhostWalker562 GhostWalker562 mentioned this pull request Nov 11, 2024
3 tasks
runtian-zhou added a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants