-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtianz/new script composer #587
base: main
Are you sure you want to change the base?
Conversation
This reverts commit bf8afa1.
Please test and validate it
|
I have tested a React + Vite client-side render app and a Next.js server-side render app. However, it's worth noting that in the current version, the initialization is done when the SDK loads, so the bundled JavaScript is a bit large—about 5 MB for the client-side. |
The bundle size is a concern. I'd like to get consensus from the sdk team before approving it. @gregnazario @GhostWalker562 |
@GhostWalker562 I dont think the SDK officially supports react-native, but I assume you want it tested for Petra? |
I think that would be amazing. |
Cool. Then we dont need to merge it to |
Let's release it first and get feedbacks from the community. I'm getting multiple asks for this feature so would be great to let them try it out first. In the meantime, we can optimize on the packaging situation. |
eagerly waiting to use this feature in our app |
Description
Reopen the script composer feature with updated dependency built into aptos-labs.
Test Plan
CI
Tested that the package can work in web, nodejs and nextjs environment.
Related Links
#565
Checklist
pnpm fmt
?CHANGELOG.md
?