-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kotlin SDK] doc update #515
Conversation
Co-authored-by: Greg Nazario <[email protected]>
Co-authored-by: Andrew Hariri <[email protected]>
Co-authored-by: Andrew Hariri <[email protected]>
Co-authored-by: Andrew Hariri <[email protected]>
- Added a section to cover the available configs across platforms
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for aptos-developer-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will let @gregnazario take a look as well
let config = ClientConfig( | ||
followRedirects: true, | ||
agent: "AptosClient", | ||
likeAgent: nil, | ||
requestTimeout: 5000, | ||
retryOnServerErrors: 3, | ||
maxRetries: 5, | ||
cache: false, | ||
proxy: nil | ||
) | ||
``` | ||
|
||
### Create the `AptosSettings` object | ||
|
||
This object is used to configure the Aptos network connection. You can set `network`, | ||
`fullnode`, and `faucet` properties. | ||
|
||
```swift filename="Main.swift" | ||
let aptosSettings = AptosSettings( | ||
network: .devnet, | ||
fullNode: nil, | ||
faucet: nil, | ||
indexer: nil, | ||
client: nil, | ||
clientConfig: config, | ||
fullNodeConfig: nil, | ||
indexerConfig: nil, | ||
faucetConfig: nil | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix indenting / formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expansion
Unless there’s a specific required indentation for the documentation, please share it. However, this formatting follows Xcode’s style, which is generally considered the recommended approach:
pnpm fmt
Not quite sure of the above command in the docs, but it barely does anything.
Thank you very much for your contribution. Currently, we have noticed that other organizations have also contributed Swift SDKs. We want to ensure that everyone’s efforts are not overlooked, and I truly appreciate your work. We can explore the possibility of showcasing different Swift SDKs on separate pages, which would allow us to present everyone’s contributions effectively and to everyone’s satisfaction. Thank you again for your valuable contributions. |
@gregnazario @WGB5445 Are we still ok with this effort? Or do we want to split out the Swift portion and leave the rest? |
We can leave that section, once this PR is done, we will move it under Community SDKs |
@astinz let's get this completed to some state that works for you, and then we're moving it under Community SDKs. |
- cover single key accounts in detail - update wording for clarification this commit provides detailed documentation for account management with the SDK
@gregnazario proceed, everything looks good on my end... |
Documentation Update
This pull request updates the documentation for
Kaptos
. The changes include: