Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subgraph: Update main subgraph + Voting subgraph and connector (#259) #259

Merged
merged 22 commits into from
Dec 30, 2020
Merged

Subgraph: Update main subgraph + Voting subgraph and connector (#259) #259

merged 22 commits into from
Dec 30, 2020

Conversation

0xGabi
Copy link
Contributor

@0xGabi 0xGabi commented Sep 2, 2020 •
edited by bpierre
Loading

Close #164, #153

This PR includes:

  • default system apps information
  • a new createdAt value for the Organization entity
  • removes metada handlers relaying on IPFS
  • implements the loadOrCreate pattern for entities

@0xGabi 0xGabi requested a review from bpierre September 2, 2020 20:49
@codecov
Copy link

codecov bot commented Sep 2, 2020 •
edited
Loading

Codecov Report

Merging #259 (ebb9a5d) into master (7ba351e) will decrease coverage by 18.62%.
The diff coverage is 16.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #259       +/-   ##
===========================================
- Coverage   39.01%   20.39%   -18.63%     
===========================================
  Files         114       74       -40     
  Lines        2099     1535      -564     
  Branches      318      324        +6     
===========================================
- Hits          819      313      -506     
+ Misses       1280     1222       -58
Flag Coverage Δ
unittests 20.39% <16.25%> (-18.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/connect-core/src/entities/App.ts 0.00% <0.00%> (ø)
packages/connect-core/src/entities/Organization.ts 0.00% <0.00%> (ø)
packages/connect-core/src/entities/Repo.ts 0.00% <0.00%> (ø)
packages/connect-core/src/entities/Role.ts 0.00% <0.00%> (ø)
packages/connect-core/src/index.ts 0.00% <0.00%> (ø)
packages/connect-core/src/params.ts 100.00% <ø> (ø)
packages/connect-core/src/utils/app-connectors.ts 0.00% <0.00%> (ø)
packages/connect-core/src/utils/app.ts 0.00% <0.00%> (ø)
packages/connect-core/src/utils/cache-store.ts 0.00% <0.00%> (ø)
packages/connect-core/src/utils/callScript.ts 0.00% <0.00%> (ø)
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbe39b5...ebb9a5d. Read the comment docs.

@0xGabi 0xGabi added this to the Update organization subgraph milestone Sep 2, 2020
0xGabi
0xGabi commented Sep 4, 2020
View reviewed changes
packages/connect-thegraph/subgraph/package.json Outdated
},
"devDependencies": {
"@graphprotocol/graph-cli": "^0.18.0",
"@graphprotocol/graph-cli": "https://github.com/graphprotocol/graph-cli",
Copy link
Contributor Author

@0xGabi 0xGabi Sep 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the master branch adds a feature to get stack traces on the graph dashboard logs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we point to a particular commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check if they already release this item and update to that version if that's the case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They already released 0.19.0 🙌

@0xGabi 0xGabi mentioned this pull request Sep 9, 2020
Merged
0xGabi and others added 19 commits September 13, 2020 20:44
@0xGabi
Subgraph: clean mappings + remove ipfs
ff73a74
@0xGabi
Subgraph: update schema and manifest data
7a24d59
@0xGabi
Merge remote-tracking branch 'origin/master' into update-org-subgraph
ecf3645
@0xGabi
Voting: fix double voting + use string for script arguments
5f3f7a5
@0xGabi
Voting: update connector
a1b0c3a
@0xGabi
Voting: bump version
77f90fe
@bpierre
Merge branch 'master' into voting-subgraph-fix
1ea3c2e
@bpierre
Casts: pass pagination params
5bfca28
@bpierre
list-votes-cli: display casts
c97848f
@bpierre
connect-voting: fix casts query
2f9c4d0
@bpierre
list-votes-cli: remove commented line
8e9b4e7
@0xGabi
Voting: fix query for casts
8ac7737
@0xGabi
Merge branch 'voting-subgraph-fix' of github.com:aragon/connect into …
5db1eae 
…voting-subgraph-fix
@bpierre
Rename variable (createAt => blockTime)
c025666
@bpierre
createAt => createdAt
1514f7a
@0xGabi
Chore: update graph-cli
117f56c
@0xGabi
Chore: select specific projects
d09107c
@0xGabi
Merge remote-tracking branch 'origin/voting-subgraph-fix' into update…
b82dece 
…-org-subgraph
@0xGabi
Voting: update docs
60b6afc
@0xGabi 0xGabi mentioned this pull request Dec 30, 2020
Closed
@0xGabi
Copy link
Contributor Author

0xGabi commented Dec 30, 2020

I'm merging this PR with a downgrade of coverage because I'm skipping both connect-agreements and connect-disputable-voting tests for now.

@0xGabi 0xGabi changed the title Subgraph: Update main subgraph Subgraph: Update main subgraph + Voting subgraph and connector (#259) Dec 30, 2020
@0xGabi 0xGabi merged commit 0601614 into master Dec 30, 2020
@0xGabi 0xGabi deleted the update-org-subgraph branch December 30, 2020 06:28
@daviddavo daviddavo mentioned this pull request Sep 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpierre bpierre Awaiting requested review from bpierre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Update organization subgraph
Development

Successfully merging this pull request may close these issues.

Subgraph: Deploy new version of main subgraph on Rinkeby to include System apps names
2 participants
@0xGabi @bpierre