Support pre-shared key #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! I will review this shortly |
aramperes
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Thank you so much for the contribution. I didn't know about this feature in WireGuard and this is a very worthwhile addition to onetun!
I made a couple changes before merging:
- I reverted to
base64==0.13.1to prevent a version conflict withboringtun. I will be able to upgrade this once Update to boringtun v0.6.x #47 is addressed - I shortened the config option to
--preshared-keyas this is configured per-peer and not strictly related to the endpoint (transport-level) - Added documentation in README
|
Thank you for the quick review! Just for reference, the PSK can be configured for each endpoint indivdually but we don't support multiple endpoints anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wireguard tunnels may be encrypted with an optional, pre-shared key. It adds an additional layer of symmetric-key cryptography for post-quantum resistance. This PR adds
--endpoint-preshared-key/ONETUN_ENDPOINT_PRESHARED_KEYto specify such a key.