[WIP] Implement atomic operations for various metrics using Prometheus as the backend storage #1487
gongna-aureviewdog.yml
on: pull_request
runner / golangci-lint
2m 49s
runner / staticcheck
2m 48s
Annotations
6 errors
|
runner / staticcheck:
pkg/metrics/manager/manager.go#L122
[staticcheck] reported by reviewdog 🐶
should use make(chan bool) instead
Raw Output:
{"source":{"name":"staticcheck","url":"https://staticcheck.io"},"message":"should use make(chan bool) instead","code":{"value":"S1019","url":"https://staticcheck.io/docs/checks#S1019"},"location":{"path":"/home/runner/work/arana/arana/pkg/metrics/manager/manager.go","range":{"start":{"line":122,"column":32}}},"severity":"ERROR"}
|
|
runner / staticcheck:
pkg/metrics/manager/manager.go#L376
[staticcheck] reported by reviewdog 🐶
unnecessary assignment to the blank identifier
Raw Output:
{"source":{"name":"staticcheck","url":"https://staticcheck.io"},"message":"unnecessary assignment to the blank identifier","code":{"value":"S1005","url":"https://staticcheck.io/docs/checks#S1005"},"location":{"path":"/home/runner/work/arana/arana/pkg/metrics/manager/manager.go","range":{"start":{"line":376,"column":11}}},"severity":"ERROR"}
|
|
runner / staticcheck:
pkg/metrics/stats/kebab_case_converter.go#L54
[staticcheck] reported by reviewdog 🐶
should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice
Raw Output:
{"source":{"name":"staticcheck","url":"https://staticcheck.io"},"message":"should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice","code":{"value":"S1007","url":"https://staticcheck.io/docs/checks#S1007"},"location":{"path":"/home/runner/work/arana/arana/pkg/metrics/stats/kebab_case_converter.go","range":{"start":{"line":54,"column":3}}},"severity":"ERROR"}
|
|
runner / staticcheck:
pkg/metrics/stats/snake_case_converter.go#L59
[staticcheck] reported by reviewdog 🐶
should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice
Raw Output:
{"source":{"name":"staticcheck","url":"https://staticcheck.io"},"message":"should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice","code":{"value":"S1007","url":"https://staticcheck.io/docs/checks#S1007"},"location":{"path":"/home/runner/work/arana/arana/pkg/metrics/stats/snake_case_converter.go","range":{"start":{"line":59,"column":3}}},"severity":"ERROR"}
|
|
runner / staticcheck:
pkg/metrics/stats/timings.go#L98
[staticcheck] reported by reviewdog 🐶
should use time.Since instead of time.Now().Sub
Raw Output:
{"source":{"name":"staticcheck","url":"https://staticcheck.io"},"message":"should use time.Since instead of time.Now().Sub","code":{"value":"S1012","url":"https://staticcheck.io/docs/checks#S1012"},"location":{"path":"/home/runner/work/arana/arana/pkg/metrics/stats/timings.go","range":{"start":{"line":98,"column":14}}},"severity":"ERROR"}
|
|
runner / staticcheck
Process completed with exit code 1.
|