Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: config ut #823

Merged
merged 1 commit into from
Jan 29, 2024
Merged

test: config ut #823

merged 1 commit into from
Jan 29, 2024

Conversation

baerwang
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #789

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

cr-gpt bot commented Jan 28, 2024

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Copy link

sonarcloud bot commented Jan 28, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
13.9% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e81d66) 40.12% compared to head (160de64) 40.20%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #823      +/-   ##
==========================================
+ Coverage   40.12%   40.20%   +0.08%     
==========================================
  Files         265      265              
  Lines       26708    26708              
==========================================
+ Hits        10716    10739      +23     
+ Misses      14841    14822      -19     
+ Partials     1151     1147       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongzl dongzl added this to the 0.3.0 milestone Jan 29, 2024
@dongzl dongzl added the test Unit test. label Jan 29, 2024
@AlexStocks AlexStocks merged commit 9b24ed9 into arana-db:master Jan 29, 2024
11 checks passed
@baerwang baerwang deleted the ut/config branch January 29, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Unit test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test] add unit test for /arana/pkg/config/config.go
4 participants