Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function support #16

Merged
merged 10 commits into from
Dec 20, 2023
Merged

Function support #16

merged 10 commits into from
Dec 20, 2023

Conversation

jaredoconnell
Copy link
Contributor

Changes introduced with this PR

This PR adds expression grammar, evaluation, type, and dependency resolution to the library.

Depends on arcalot/arcaflow-plugin-sdk-go#68

By contributing to this repository, I agree to the contribution guidelines.

@jaredoconnell jaredoconnell mentioned this pull request Dec 7, 2023
Merged
@jaredoconnell jaredoconnell marked this pull request as ready for review December 14, 2023 22:22
jaredoconnell
jaredoconnell commented Dec 19, 2023
View reviewed changes
expression_evaluate.go Outdated Show resolved Hide resolved
expression_evaluate_test.go Show resolved Hide resolved
internal/ast/ast.go Outdated Show resolved Hide resolved
internal/ast/ast.go Outdated Show resolved Hide resolved
internal/ast/grammar_test.go Show resolved Hide resolved
webbnh
webbnh reviewed Dec 19, 2023
View reviewed changes
expression_dependencies.go Outdated Show resolved Hide resolved
expression_dependencies.go Outdated Show resolved Hide resolved
expression_dependencies.go Outdated Show resolved Hide resolved
expression_dependencies_test.go Outdated Show resolved Hide resolved
expression_evaluate.go Outdated Show resolved Hide resolved
expression_evaluate.go Outdated Show resolved Hide resolved
expression_evaluate.go Outdated Show resolved Hide resolved
webbnh
webbnh approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good except for a spot where a function header comment needs amendment. I've also got a couple of coding suggestions.

And, I still have a question about why bracket expressions need special handling for literals.

expression_dependencies.go Outdated Show resolved Hide resolved
expression_evaluate.go Outdated Show resolved Hide resolved
internal/ast/grammar_test.go Show resolved Hide resolved
expression_dependencies.go Show resolved Hide resolved
@jaredoconnell jaredoconnell merged commit 7368236 into main Dec 20, 2023
4 checks passed
@jaredoconnell jaredoconnell deleted the function-support branch December 20, 2023 22:22
@dustinblack dustinblack mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webbnh webbnh webbnh approved these changes

@mfleader mfleader mfleader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaredoconnell @webbnh @mfleader