Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValidateCompatibility fix #49

Merged
merged 2 commits into from
Aug 22, 2023
Merged

ValidateCompatibility fix #49

merged 2 commits into from
Aug 22, 2023

Conversation

jaredoconnell
Copy link
Contributor

Changes introduced with this PR

This fixes:

  • The segmentation fault I encountered due to a nil name
  • An error when discriminator is present in the object.

By contributing to this repository, I agree to the contribution guidelines.

jdowni000
jdowni000 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@jdowni000 jdowni000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaredoconnell jaredoconnell merged commit dac3c92 into main Aug 22, 2023
3 checks passed
@jaredoconnell jaredoconnell deleted the validatecompatibility-fix branch August 22, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdowni000 jdowni000 jdowni000 approved these changes

@dustinblack dustinblack Awaiting requested review from dustinblack

@mfleader mfleader Awaiting requested review from mfleader

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredoconnell @jdowni000