Added namespaced scopes #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
reviewed
Feb 22, 2024
mfleader
approved these changes
Feb 22, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
I updated the link to point to a draft PR instead. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
dbutenhof
reviewed
Mar 21, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
dbutenhof
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
This PR adds namespaced references, allowing scopes only under a certain namespace to apply.
This allows referencing objects from other scopes without ID collisions.
To make this work, references have an optional namespace field, and ApplyScope has a namespace field so that it knows which refs it applies to.
Since an apply scope may happen after initial construction of the scope, an additional method,
ValidateReferences, is added to ensure that all scopes are applied.As designed, an empty string is considered the default scope. Let me know if you think that should be changed.
Example of use: arcalot/arcaflow-engine#167
By contributing to this repository, I agree to the contribution guidelines.