Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go updates #102

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Update go updates #102

merged 1 commit into from
Nov 6, 2024

Conversation

redhat-renovate-bot
Copy link
Contributor

@redhat-renovate-bot redhat-renovate-bot commented Nov 4, 2024

This PR contains the following updates:

Package Type Update Change
gopkg.in/yaml.v2 indirect major v2.4.0 -> v3.0.1
k8s.io/kube-openapi indirect digest 67ed584 -> 32ad38e
k8s.io/utils indirect digest 49e7df5 -> 6fe5fd8
sigs.k8s.io/json indirect digest bc3834c -> cfa47c3
sigs.k8s.io/structured-merge-diff/v4 indirect patch v4.4.1 -> v4.4.2

Release Notes

go-yaml/yaml (gopkg.in/yaml.v2)

v3.0.1

Compare Source

v3.0.0

Compare Source

kubernetes-sigs/structured-merge-diff (sigs.k8s.io/structured-merge-diff/v4)

v4.4.2

Compare Source


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@redhat-renovate-bot
Copy link
Contributor Author

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go.sum
Command failed: go get -d -t ./...
go: go.mod requires go >= 1.22.8 (running go 1.21.13; GOTOOLCHAIN=local)

Copy link
Contributor

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to manually run go get and go mod tidy.

Signed-off-by: redhat-renovate-bot <[email protected]>
@webbnh
Copy link
Contributor

webbnh commented Nov 6, 2024

The update to sigs.k8s.io/structured-merge-diff/[email protected] seems to run into a problem with k8s.io/[email protected] (unknown field IgnoredFields in struct literal of type merge.Updater), as though their dependencies aren't declared properly.

But, I took the opportunity to update k8s.io/kube-openapi and k8s.io/utils. (The update to sigs.k8s.io/json requires an update to Go itself.)

@webbnh webbnh merged commit 90bc275 into main Nov 6, 2024
4 checks passed
@webbnh webbnh deleted the renovate/go-updates branch November 6, 2024 22:00
@webbnh
Copy link
Contributor

webbnh commented Nov 6, 2024

I took the opportunity to update k8s.io/kube-openapi and k8s.io/utils.

Actually, I wasn't watching closely enough: Go actually downgraded k8s.io/kube-openapi for us. 😒

I thought that "loosening" our Go requirement from 1.22.8 to 1.22.0 would better express our needs, but it looks like that change was propagated to our expressed indirect requirements, which is "interesting". And, the build shows that, even though we (inappropriately) built with 1.23, Go honored our stated indirect dependency requirements and downloaded the old versions. 😝

Right at this moment, I'm not seeing any value in maintaining our list of indirect dependencies. 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants