-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated pf1 mapping. #79
base: main
Are you sure you want to change the base?
Updated pf1 mapping. #79
Conversation
…sion 10 data model
@arvoituksellinen I have tried this new PF1 mapping with the most recent updated pdf-sheet scripts (updated this week) and I get the following errors:
and later,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the errors that happen when trying to export a character using the latest version of the repository with your mapping.
Just to have a better understanding is a mapping problem in pf1? or in PF2? Which version of foundry are you using? I do not use PF so cannot test it |
This PR is a pf1 mapping. I tried testing it in PF1. I'm not too familiar
with pf1, but I created a PC and tried to export it and it failed as
noted. It likely worked when the original author first submitted it, but
it needs to be modified now to work again.
…On Fri, Aug 25, 2023 at 3:40 AM Luca Gioppo ***@***.***> wrote:
Just to have a better understanding is a mapping problem in pf1? or in
PF2? Which version of foundry are you using? I do not use PF so cannot test
it
—
Reply to this email directly, view it on GitHub
<#79 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZVCVE4QGKZPQA43KYOLJTXXB6ITANCNFSM6AAAAAAXPKIKTM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This means that the content of this PR is not valid. |
Here is partially working mapping file. There are some issues like "med" instead of size modifier, but it's better than nothing and can be used to some degree: Tested on foundry version 11 build 308, PF1 version 9.4 |
@imposeren Thanks for updating this. If I get time, I'll try to update it further, languages aren't coming through either. It is a good stop gap. |
@imposeren thanks for the mapping, it's a good starting point that is at least functional, with the caveats you mentioned. |
Fixes due to breaking changes in Foundry vtt version 10 data model