Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pf1 mapping. #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arvoituksellinen
Copy link

Fixes due to breaking changes in Foundry vtt version 10 data model

@dyoung418
Copy link
Contributor

@arvoituksellinen I have tried this new PF1 mapping with the most recent updated pdf-sheet scripts (updated this week) and I get the following errors:

foundry.js:68095 PDF Sheet | Invalid mapping JavaScript Object. See the <a href="https://github.com/arcanistzed/pdf-sheet/blob/main/README.md">README</a> for more info.

and later,

VM3345:3 Uncaught TypeError: Cannot read properties of undefined (reading 'alignment')
    at eval (eval at createForm (pdfsheet.js:264:4), <anonymous>:3:393)
    at Pdfconfig.createForm (pdfsheet.js:264:77)
    at Pdfconfig.onFileUpload (pdfsheet.js:393:8)
    at reader.onload (pdfsheet.js:192:31)

Copy link
Contributor

@dyoung418 dyoung418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the errors that happen when trying to export a character using the latest version of the repository with your mapping.

@gioppoluca
Copy link
Collaborator

Just to have a better understanding is a mapping problem in pf1? or in PF2? Which version of foundry are you using? I do not use PF so cannot test it

@dyoung418
Copy link
Contributor

dyoung418 commented Aug 25, 2023 via email

@gioppoluca
Copy link
Collaborator

This means that the content of this PR is not valid.
In this case we'll not approve it thanks.
Hope that someone will take a look at PF1 mapping and make it work again.

@imposeren
Copy link

Here is partially working mapping file. There are some issues like "med" instead of size modifier, but it's better than nothing and can be used to some degree:
pf1.mapping.txt

Tested on foundry version 11 build 308, PF1 version 9.4

@jpverhaeghe
Copy link

@imposeren Thanks for updating this. If I get time, I'll try to update it further, languages aren't coming through either. It is a good stop gap.

@eyenology
Copy link

@imposeren thanks for the mapping, it's a good starting point that is at least functional, with the caveats you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants