Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force enable and reset to be low when deiniting chip #285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ircmaxell
Copy link

Currently, when deiniting the WiFi chip via WiFi.end(), the enable pin is left floating.

As per the data sheet section 8.4 (Power up/down sequence), both the enable and reset pins must be asserted high or low, and never left floating:

CHIP_EN must not rise before VDDIO. CHIP_EN must be driven high or low, not left floating

RESETN must be driven high or low, not left floating.

This PR addresses this by ensuring both pins are output (enable was INPUT_PULLUP), and force asserting both pins low on deinit. This appears safe, as the enable and reset pins do not appear to be used by any other piece of code in the WiFi101 library.

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ircmaxell
Copy link
Author

When I click the link, it does not show me an eligible version of the CLA to sign for. Just a blank list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants