Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WiFiClient.setConnectionTimeout added #329

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WiFiClient.setConnectionTimeout added #329

wants to merge 1 commit into from

Conversation

JAndrassy
Copy link

@JAndrassy JAndrassy commented Feb 6, 2022 •
edited
Loading

the connection timeout in WiFi101 library was hardcoded and is unreasonable long 20 seconds.
the Ethernet library has setConnectionTimeout.
this PR adds setConnectionTimeout to WiFiClient.
default timeout is still 20 seconds but can be set with -DWIFI101_CLIENT_CONNECTION_TIMEOUT

overview of Client API in Arduino networking libraries:
https://github.com/JAndrassy/Arduino-Networking-API/blob/main/ArduinoNetAPILibs.md#client-getters-and-setters

@github-actions
Copy link

github-actions bot commented Feb 6, 2022

Memory usage change @ bed2bc8

Board flash % RAM for global variables %
Intel:arc32:arduino_101 🔺 0 - +24 0.0 - +0.02 N/A N/A
arduino:avr:mega 🔺 0 - +60 0.0 - +0.02 🔺 0 - +2 0.0 - +0.02
arduino:avr:uno 🔺 0 - +74 0.0 - +0.23 🔺 0 - +2 0.0 - +0.1
arduino:sam:arduino_due_x_dbg 🔺 0 - +16 0.0 - 0.0 N/A N/A
arduino:samd:arduino_zero_edbg 🔺 0 - +24 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 🔺 0 - +24 0.0 - +0.01 0 - 0 0.0 - 0.0
Click for full report table
Board examples/AP_SimpleWebServer
flash		 % examples/AP_SimpleWebServer
RAM for global variables		 % examples/CheckWifi101FirmwareVersion
flash		 % examples/CheckWifi101FirmwareVersion
RAM for global variables		 % examples/ConnectNoEncryption
flash		 % examples/ConnectNoEncryption
RAM for global variables		 % examples/ConnectWithWEP
flash		 % examples/ConnectWithWEP
RAM for global variables		 % examples/ConnectWithWPA
flash		 % examples/ConnectWithWPA
RAM for global variables		 % examples/MDNS_WiFiWebServer
flash		 % examples/MDNS_WiFiWebServer
RAM for global variables		 % examples/Provisioning_WiFiWebServer
flash		 % examples/Provisioning_WiFiWebServer
RAM for global variables		 % examples/ScanNetworks
flash		 % examples/ScanNetworks
RAM for global variables		 % examples/ScanNetworksAdvanced
flash		 % examples/ScanNetworksAdvanced
RAM for global variables		 % examples/SimpleWebServerWiFi
flash		 % examples/SimpleWebServerWiFi
RAM for global variables		 % examples/WiFiChatServer
flash		 % examples/WiFiChatServer
RAM for global variables		 % examples/WiFiPing
flash		 % examples/WiFiPing
RAM for global variables		 % examples/WiFiSSLClient
flash		 % examples/WiFiSSLClient
RAM for global variables		 % examples/WiFiUdpNtpClient
flash		 % examples/WiFiUdpNtpClient
RAM for global variables		 % examples/WiFiUdpSendReceiveString
flash		 % examples/WiFiUdpSendReceiveString
RAM for global variables		 % examples/WiFiWebClient
flash		 % examples/WiFiWebClient
RAM for global variables		 % examples/WiFiWebClientRepeating
flash		 % examples/WiFiWebClientRepeating
RAM for global variables		 % examples/WiFiWebServer
flash		 % examples/WiFiWebServer
RAM for global variables		 % examples/FirmwareUpdater
flash		 % examples/FirmwareUpdater
RAM for global variables		 %
Intel:arc32:arduino_101 24 0.02 N/A N/A 0 0.0 N/A N/A 0 0.0 N/A N/A 0 0.0 N/A N/A 0 0.0 N/A N/A 24 0.02 N/A N/A 24 0.02 N/A N/A 0 0.0 N/A N/A 0 0.0 N/A N/A 24 0.02 N/A N/A 24 0.02 N/A N/A 0 0.0 N/A N/A 16 0.01 N/A N/A 0 0.0 N/A N/A 0 0.0 N/A N/A 16 0.01 N/A N/A 16 0.01 N/A N/A 24 0.02 N/A N/A 0 0.0 N/A N/A
arduino:avr:mega 60 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 40 0.02 0 0.0 40 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 24 0.01 0 0.0 26 0.01 0 0.0 0 0.0 0 0.0 32 0.01 2 0.02 0 0.0 0 0.0 0 0.0 0 0.0 34 0.01 2 0.02 34 0.01 2 0.02 34 0.01 0 0.0
arduino:avr:uno 74 0.23 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 40 0.12 0 0.0 40 0.12 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 30 0.09 0 0.0 30 0.09 0 0.0 0 0.0 0 0.0 32 0.1 2 0.1 0 0.0 0 0.0 0 0.0 0 0.0 34 0.11 2 0.1 34 0.11 2 0.1 30 0.09 0 0.0
arduino:sam:arduino_due_x_dbg 16 0.0 N/A N/A 0 0.0 N/A N/A 0 0.0 N/A N/A 0 0.0 N/A N/A 0 0.0 N/A N/A 16 0.0 N/A N/A 16 0.0 N/A N/A 0 0.0 N/A N/A 0 0.0 N/A N/A 16 0.0 N/A N/A 16 0.0 N/A N/A 0 0.0 N/A N/A 16 0.0 N/A N/A 0 0.0 N/A N/A 0 0.0 N/A N/A 8 0.0 N/A N/A 16 0.0 N/A N/A 16 0.0 N/A N/A 0 0.0 N/A N/A
arduino:samd:arduino_zero_edbg 16 0.01 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 24 0.01 0 0.0 16 0.01 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 0 0.0 0 0.0 8 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 16 0.01 0 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 16 0.01 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 16 0.01 0 0.0 24 0.01 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 0 0.0 0 0.0 8 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 16 0.01 0 0.0 8 0.0 0 0.0 16 0.01 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/AP_SimpleWebServer<br>flash,%,examples/AP_SimpleWebServer<br>RAM for global variables,%,examples/CheckWifi101FirmwareVersion<br>flash,%,examples/CheckWifi101FirmwareVersion<br>RAM for global variables,%,examples/ConnectNoEncryption<br>flash,%,examples/ConnectNoEncryption<br>RAM for global variables,%,examples/ConnectWithWEP<br>flash,%,examples/ConnectWithWEP<br>RAM for global variables,%,examples/ConnectWithWPA<br>flash,%,examples/ConnectWithWPA<br>RAM for global variables,%,examples/MDNS_WiFiWebServer<br>flash,%,examples/MDNS_WiFiWebServer<br>RAM for global variables,%,examples/Provisioning_WiFiWebServer<br>flash,%,examples/Provisioning_WiFiWebServer<br>RAM for global variables,%,examples/ScanNetworks<br>flash,%,examples/ScanNetworks<br>RAM for global variables,%,examples/ScanNetworksAdvanced<br>flash,%,examples/ScanNetworksAdvanced<br>RAM for global variables,%,examples/SimpleWebServerWiFi<br>flash,%,examples/SimpleWebServerWiFi<br>RAM for global variables,%,examples/WiFiChatServer<br>flash,%,examples/WiFiChatServer<br>RAM for global variables,%,examples/WiFiPing<br>flash,%,examples/WiFiPing<br>RAM for global variables,%,examples/WiFiSSLClient<br>flash,%,examples/WiFiSSLClient<br>RAM for global variables,%,examples/WiFiUdpNtpClient<br>flash,%,examples/WiFiUdpNtpClient<br>RAM for global variables,%,examples/WiFiUdpSendReceiveString<br>flash,%,examples/WiFiUdpSendReceiveString<br>RAM for global variables,%,examples/WiFiWebClient<br>flash,%,examples/WiFiWebClient<br>RAM for global variables,%,examples/WiFiWebClientRepeating<br>flash,%,examples/WiFiWebClientRepeating<br>RAM for global variables,%,examples/WiFiWebServer<br>flash,%,examples/WiFiWebServer<br>RAM for global variables,%,examples/FirmwareUpdater<br>flash,%,examples/FirmwareUpdater<br>RAM for global variables,%
Intel:arc32:arduino_101,24,0.02,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,24,0.02,N/A,N/A,24,0.02,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,24,0.02,N/A,N/A,24,0.02,N/A,N/A,0,0.0,N/A,N/A,16,0.01,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,16,0.01,N/A,N/A,16,0.01,N/A,N/A,24,0.02,N/A,N/A,0,0.0,N/A,N/A
arduino:avr:mega,60,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,40,0.02,0,0.0,40,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,24,0.01,0,0.0,26,0.01,0,0.0,0,0.0,0,0.0,32,0.01,2,0.02,0,0.0,0,0.0,0,0.0,0,0.0,34,0.01,2,0.02,34,0.01,2,0.02,34,0.01,0,0.0,,,,
arduino:avr:uno,74,0.23,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,40,0.12,0,0.0,40,0.12,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,30,0.09,0,0.0,30,0.09,0,0.0,0,0.0,0,0.0,32,0.1,2,0.1,0,0.0,0,0.0,0,0.0,0,0.0,34,0.11,2,0.1,34,0.11,2,0.1,30,0.09,0,0.0,,,,
arduino:sam:arduino_due_x_dbg,16,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,16,0.0,N/A,N/A,16,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,16,0.0,N/A,N/A,16,0.0,N/A,N/A,0,0.0,N/A,N/A,16,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,8,0.0,N/A,N/A,16,0.0,N/A,N/A,16,0.0,N/A,N/A,0,0.0,N/A,N/A
arduino:samd:arduino_zero_edbg,16,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,24,0.01,0,0.0,16,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,16,0.01,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,16,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,16,0.01,0,0.0,24,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,16,0.01,0,0.0,8,0.0,0,0.0,16,0.01,0,0.0,0,0.0,0,0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JAndrassy