Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WiFiS3 At improvements #349

Merged
merged 4 commits into from
Nov 27, 2024
Merged

WiFiS3 At improvements #349

merged 4 commits into from
Nov 27, 2024

Conversation

andreagilardoni
Copy link
Contributor

Improving the AT parsing function

@andreagilardoni andreagilardoni changed the title [WIP] At improvements [WIP] WifiS3 At improvements Jul 17, 2024
@andreagilardoni andreagilardoni changed the title [WIP] WifiS3 At improvements [WIP] WiFiS3 At improvements Jul 17, 2024
@andreagilardoni andreagilardoni marked this pull request as ready for review July 22, 2024 10:23
@andreagilardoni andreagilardoni changed the title [WIP] WiFiS3 At improvements WiFiS3 At improvements Jul 22, 2024
@andreagilardoni andreagilardoni requested a review from pennam July 22, 2024 10:26
@andreagilardoni andreagilardoni mentioned this pull request Jul 25, 2024
Open
@pennam pennam mentioned this pull request Aug 7, 2024
Merged
@pennam
Copy link
Contributor

pennam commented Aug 9, 2024 •
edited
Loading

Testing core sketches using AT commands:
OTA 👍
StartCounter 👍
Prefs2Struct 👍
SATSECertificate 👎 Timeout error
SATSEPrivateKey 👍
SATSERandomNumber 👍
SATSESerialNumber 👍
SATSESignAndVerify 👎
WiFiWebServer 👍
WiFiWebClientSSL 👍
WiFiWebClientRepeating 👍

@andreagilardoni andreagilardoni force-pushed the at-improvements branch 2 times, most recently from d04da60 to 649ecb8 Compare November 19, 2024 16:01
@andreagilardoni
Copy link
Contributor Author

Fixed the issue that was making the tests @pennam mentioned in the previous comment: https://github.com/andreagilardoni/ArduinoCore-renesas/blob/649ecb8b5fa2665fc555a1cd29440b85b6614cac/libraries/WiFiS3/src/Modem.cpp#L229
The issue is that we cannot check the response prompt in passthrough mode since we lack the knowledge of the previously sent command. The line will be preserved with a comment indicating that when solved this could help improving the reliability of the protocol, since it enforces a command to have a response with a matching prompt.

@andreagilardoni andreagilardoni force-pushed the at-improvements branch 2 times, most recently from 6d1bc4c to c09ffd6 Compare November 19, 2024 16:22
@andreagilardoni andreagilardoni mentioned this pull request Nov 20, 2024
Closed
@andreagilardoni @pennam
Unifying codestyle
e817519
@andreagilardoni @pennam
Improving parse function in modem class
ccd5d5c 
This commit aims to change the logic of the parse function from
repeatedly calling a find on the buffer of incoming data to an approach
based on FSM for parsing a stream of chars
@andreagilardoni @pennam
adding a third level of debug
cf5ea5e
@andreagilardoni @pennam
removing unused methods
f33f6e3
@pennam
Copy link
Contributor

pennam commented Nov 27, 2024 •
edited
Loading

Testing core sketches using AT commands:

Sketch 0.5.0 0.4.1
OTA 👍 👍
StartCounter 👍 👍
Prefs2Struct 👍 👍
SATSECertificate 👍 👍
SATSEPrivateKey 👍 👍
SATSERandomNumber 👍 👍
SATSESerialNumber 👍 👍
SATSESignAndVerify 👍 👍
WiFiWebServer 👍 👍
WiFiWebClientSSL 👍 👍
WiFiWebClientRepeating 👍 👍

@pennam pennam merged commit 69dbc7d into arduino:main Nov 27, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pennam pennam pennam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreagilardoni @pennam