Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preferences fixes #393

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Preferences fixes #393

merged 3 commits into from
Nov 28, 2024

Conversation

andreagilardoni
Copy link
Contributor

This PR address the following points

  • lacking api for getType
  • improving the communication of strings for preferences values

This PR depends on arduino/uno-r4-wifi-usb-bridge#62

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Nov 15, 2024
@andreagilardoni andreagilardoni changed the title Prefernces fixes Preferences fixes Nov 18, 2024
@andreagilardoni andreagilardoni mentioned this pull request Nov 20, 2024
Closed
@pennam
Copy link
Contributor

pennam commented Nov 27, 2024

NOTE: 30ba157 breaks string handling for older firmware releases since needs arduino/uno-r4-wifi-usb-bridge#62 that is included in uno-r4-wifi-usb-bridge https://github.com/arduino/uno-r4-wifi-usb-bridge/releases/tag/0.5.0

@pennam pennam merged commit 7c59871 into arduino:main Nov 28, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreagilardoni @pennam @per1234