Fix MacOS write error caused by unflushed buffer #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@facchinm, I am hoping that we can create a patch release for this and upload it to the Arduino package repository. What is the process for that? |
|
I had to make this modification locally in order to flash SAM parts. This pull request has been around for ages, it would be nice to get it merged. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is actually a cherry-picked code change from a pull request to shumatech/BOSSA. Special thanks to @kaysievers for this code (see issues: Bossa 1.9.1 occasionally fails mid-download #120 and the subsequent resolution in Pull Request #150)
This change resolved an issue where (I suppose) flash has not been properly erased prior to writing the new code. This results in a verify error and requires code to be re-flashed to the SAMD21.
PosixSerialPort: Call tcdrain() to write serial data