[skip-changelog] Remove most of the direct accesses to arduino package
#2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2296 +/- ##
==========================================
- Coverage 63.07% 63.04% -0.04%
==========================================
Files 200 201 +1
Lines 19265 19268 +3
==========================================
- Hits 12152 12147 -5
- Misses 6063 6067 +4
- Partials 1050 1054 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
MatteoPologruto
force-pushed
the
move-warn-deprecated-to-commands
branch
from
a2fc690 to
622714f
Compare
cmaglie
requested changes
Sep 11, 2023
MatteoPologruto
force-pushed
the
move-warn-deprecated-to-commands
branch
2 times, most recently
from
11b4de8 to
23f8603
Compare
cmaglie
approved these changes
Sep 20, 2023
MatteoPologruto
force-pushed
the
move-warn-deprecated-to-commands
branch
from
ea4c772 to
11326b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
No changes. The CLI code now relies more on the gRPC interface.
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Follow up to: #2292 and #2297