Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting legacy tests to new integration-test infra (part 3...) #2300

Merged
merged 12 commits into from
Sep 8, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 7, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Ported tests from the legacy infrastructure to the current one.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Sep 7, 2023
@cmaglie cmaglie self-assigned this Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 94.11% and project coverage change: +0.01% 🎉

Comparison is base (72c32ca) 63.35% compared to head (3d8d37d) 63.37%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2300      +/-   ##
==========================================
+ Coverage   63.35%   63.37%   +0.01%     
==========================================
  Files         214      214              
  Lines       19569    19551      -18     
==========================================
- Hits        12398    12390       -8     
+ Misses       6084     6075       -9     
+ Partials     1087     1086       -1     
Flag Coverage Δ
unit 63.37% <94.11%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
legacy/builder/test/helper.go 79.16% <66.66%> (+19.64%) ⬆️
legacy/builder/test/helper_tools_downloader.go 60.80% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit 1c110e9 into arduino:master Sep 8, 2023
92 checks passed
@cmaglie cmaglie deleted the factoring_tests branch September 8, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants