Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] gRPC / golang Configuration API refactoring #2565

Merged
merged 56 commits into from
May 15, 2024

Improved array handling in configmap, and unit-tests

cec1fdb
Select commit
Loading
Failed to load commit list.
Merged

[BREAKING] gRPC / golang Configuration API refactoring #2565

Improved array handling in configmap, and unit-tests
cec1fdb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 15, 2024 in 0s

70.13% (target 30.00%)

View this Pull Request on Codecov

70.13% (target 30.00%)

Details

Codecov Report

Attention: Patch coverage is 74.24299% with 689 lines in your changes are missing coverage. Please review.

Project coverage is 70.13%. Comparing base (03d8653) to head (cec1fdb).
Report is 4 commits behind head on master.

Files Patch % Lines
internal/go-configmap/types.go 46.52% 69 Missing and 8 partials ⚠️
commands/service_monitor.go 62.69% 53 Missing and 19 partials ⚠️
commands/service_settings.go 69.51% 39 Missing and 11 partials ⚠️
commands/cmderrors/cmderrors.go 14.89% 40 Missing ⚠️
commands/instances.go 72.91% 30 Missing and 9 partials ⚠️
commands/service_upload_burnbootloader.go 0.00% 35 Missing ⚠️
commands/service_upload.go 54.41% 29 Missing and 2 partials ⚠️
commands/service_compile.go 66.66% 24 Missing and 4 partials ⚠️
internal/go-configmap/cli.go 65.07% 16 Missing and 6 partials ⚠️
internal/cli/config/init.go 64.40% 12 Missing and 9 partials ⚠️
... and 50 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2565      +/-   ##
==========================================
+ Coverage   69.51%   70.13%   +0.61%     
==========================================
  Files         207      222      +15     
  Lines       20285    21124     +839     
==========================================
+ Hits        14102    14816     +714     
- Misses       5069     5132      +63     
- Partials     1114     1176      +62

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov