-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force the use of the latest prettier in general:format-prettier
task
#2626
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2626 +/- ##
=======================================
Coverage 70.29% 70.29%
=======================================
Files 222 222
Lines 21308 21308
=======================================
Hits 14978 14978
Misses 5153 5153
Partials 1177 1177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The standard approach is to use npm to manage the Prettier dependency:
This way you can perform controlled updates of Prettier instead of being immediately subject to breaking changes that are introduced by a new release of the tool.
I see, I've updated the PR accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on linux, it correctly picks up the pinned version
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Force the use of the same prettier version as in the CI.
What is the current behavior?
The CI may use a more recent version of the
prettier
tool since it's installed fresh at each run.What is the new behavior?
The local task now forces the update of the
prettier
tool if available.Does this PR introduce a breaking change, and is titled accordingly?
Other information