configuration: env vars with array values rendered as a single string #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
alessio-perugini
added
type: imperfection
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2644 +/- ##
==========================================
+ Coverage 70.29% 70.31% +0.02%
==========================================
Files 222 222
Lines 21308 21318 +10
==========================================
+ Hits 14978 14990 +12
+ Misses 5153 5151 -2
Partials 1177 1177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alessio-perugini
force-pushed
the
fix-26-43
branch
from
6e7613b to
6f46e00
Compare
|
superseeded by #2645 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Fix a regression in passing multiple values to a single env var that wasn't correctly expanded.
What is the current behavior?
When passing multiple values in a single env var, they are rendered a single string, causing unexpected behaviors.
What is the new behavior?
Now we treat such values as multiple values and not as a single string. We split them by whitespace.
Does this PR introduce a breaking change, and is titled accordingly?
Other information