Refactor instanceof to use pattern variable.

Closes spring-projects#3586
arefbehboudi · Aug 20, 2024 · a389415 · a389415
1 parent 06212b5
commit a389415
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 24 deletions.
diff --git a/...data-jpa/src/main/java/org/springframework/data/jpa/repository/query/EscapeCharacter.java b/...data-jpa/src/main/java/org/springframework/data/jpa/repository/query/EscapeCharacter.java
@@ -69,11 +69,10 @@ public boolean equals(Object o) {
 			return true;
 		}
 
-		if (!(o instanceof EscapeCharacter)) {
+		if (!(o instanceof EscapeCharacter that)) {
 			return false;
 		}
 
-		EscapeCharacter that = (EscapeCharacter) o;
 		return escapeCharacter == that.escapeCharacter;
 	}
 

diff --git a/...ata-jpa/src/main/java/org/springframework/data/jpa/repository/query/ParameterBinding.java b/...ata-jpa/src/main/java/org/springframework/data/jpa/repository/query/ParameterBinding.java
@@ -279,12 +279,10 @@ public Object prepare(@Nullable Object value) {
 		@Override
 		public boolean equals(Object obj) {
 
-			if (!(obj instanceof LikeParameterBinding)) {
+			if (!(obj instanceof LikeParameterBinding that)) {
 				return false;
 			}
 
-			LikeParameterBinding that = (LikeParameterBinding) obj;
-
 			return super.equals(obj) && this.type.equals(that.type);
 		}
 

diff --git a/...a-jpa/src/main/java/org/springframework/data/jpa/repository/query/ProcedureParameter.java b/...a-jpa/src/main/java/org/springframework/data/jpa/repository/query/ProcedureParameter.java
@@ -77,11 +77,10 @@ public boolean equals(Object o) {
 			return true;
 		}
 
-		if (!(o instanceof ProcedureParameter)) {
+		if (!(o instanceof ProcedureParameter that)) {
 			return false;
 		}
 
-		ProcedureParameter that = (ProcedureParameter) o;
 		return Objects.equals(name, that.name) && mode == that.mode && Objects.equals(type, that.type);
 	}
 

diff --git a/spring-data-jpa/src/main/java/org/springframework/data/jpa/util/BeanDefinitionUtils.java b/spring-data-jpa/src/main/java/org/springframework/data/jpa/util/BeanDefinitionUtils.java
@@ -223,12 +223,10 @@ public boolean equals(Object o) {
 				return true;
 			}
 
-			if (!(o instanceof EntityManagerFactoryBeanDefinition)) {
+			if (!(o instanceof EntityManagerFactoryBeanDefinition that)) {
 				return false;
 			}
 
-			EntityManagerFactoryBeanDefinition that = (EntityManagerFactoryBeanDefinition) o;
-
 			if (!ObjectUtils.nullSafeEquals(beanName, that.beanName)) {
 				return false;
 			}

diff --git a/spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/ItemId.java b/spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/ItemId.java
@@ -58,11 +58,9 @@ public void setManufacturerId(Integer manufacturerId) {
 	public boolean equals(Object o) {
 		if (this == o)
 			return true;
-		if (!(o instanceof ItemId))
+		if (!(o instanceof ItemId itemId))
 			return false;
 
-		ItemId itemId = (ItemId) o;
-
 		if (id != null ? !id.equals(itemId.id) : itemId.id != null)
 			return false;
 		return manufacturerId != null ? manufacturerId.equals(itemId.manufacturerId) : itemId.manufacturerId == null;

diff --git a/spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/ItemSiteId.java b/spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/ItemSiteId.java
@@ -42,11 +42,9 @@ public ItemSiteId(ItemId item, Integer site) {
 	public boolean equals(Object o) {
 		if (this == o)
 			return true;
-		if (!(o instanceof ItemSiteId))
+		if (!(o instanceof ItemSiteId that))
 			return false;
 
-		ItemSiteId that = (ItemSiteId) o;
-
 		if (item != null ? !item.equals(that.item) : that.item != null)
 			return false;
 		return site != null ? site.equals(that.site) : that.site == null;

diff --git a/...-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/SampleWithIdClass.java b/...-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/SampleWithIdClass.java
@@ -1,13 +1,13 @@
 package org.springframework.data.jpa.domain.sample;
 
-import java.io.Serializable;
-
 import jakarta.persistence.Access;
 import jakarta.persistence.AccessType;
 import jakarta.persistence.Entity;
 import jakarta.persistence.Id;
 import jakarta.persistence.IdClass;
 
+import java.io.Serializable;
+
 @Entity
 @IdClass(SampleWithIdClass.SampleWithIdClassPK.class)
 @Access(AccessType.FIELD)
@@ -29,12 +29,10 @@ public boolean equals(Object obj) {
 				return true;
 			}
 
-			if (!(obj instanceof SampleWithIdClassPK)) {
+			if (!(obj instanceof SampleWithIdClassPK that)) {
 				return false;
 			}
 
-			SampleWithIdClassPK that = (SampleWithIdClassPK) obj;
-
 			return this.first.equals(that.first) && this.second.equals(that.second);
 		}
 

diff --git a/spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/User.java b/spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/User.java
@@ -284,12 +284,10 @@ public byte[] getBinaryData() {
 	@Override
 	public boolean equals(Object obj) {
 
-		if (!(obj instanceof User)) {
+		if (!(obj instanceof User that)) {
 			return false;
 		}
 
-		User that = (User) obj;
-
 		if ((null == this.getId()) || (null == that.getId())) {
 			return false;
 		}