Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triso no growth deployment setup Scenario: DAN4 #170

Merged
merged 15 commits into from
Oct 3, 2024

Conversation

nsryan2
Copy link
Member

@nsryan2 nsryan2 commented Sep 23, 2024

This PR setups up the growth deployment calculations using reactor deployment for the no growth scenario using the greedy, rough random, and rough + greedy deployment schemes.

The no growth scenario is a 0% demand increase year-to-year starting in 2029 when the advanced reactors will begin deployment. Each deployment scheme attempts to meet this demand with pre-defined reactor models. Currently there are only Xe-100s and MMRs, this will be expanded (there is an issue #171 associated with this).

It also includes a README with basic information about the triso project with scenarios, updates the lwr_csv to include Voglte 3 and 4, and adds a style file for plotting uniformly in the folder.

@pep8speaks
Copy link
Contributor

pep8speaks commented Sep 24, 2024

Hello @nsryan2! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-10-03 18:42:58 UTC

@nsryan2 nsryan2 changed the title Triso no growth deployment setup Triso no growth deployment setup Scenario: DAN4 Sep 24, 2024
@nsryan2 nsryan2 marked this pull request as draft September 24, 2024 18:45
@nsryan2 nsryan2 marked this pull request as ready for review September 30, 2024 13:33
Copy link
Contributor

@LukeSeifert LukeSeifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just had one or two minor comments on things

scenarios/triso/README.md Outdated Show resolved Hide resolved
scenarios/triso/README.md Show resolved Hide resolved
scenarios/triso/deployment_calcs/lwr_info.csv Outdated Show resolved Hide resolved
scenarios/triso/deployment_calcs/lwr_info.csv Outdated Show resolved Hide resolved
scenarios/triso/deployment_calcs/growth_calculations.ipynb Outdated Show resolved Hide resolved
scenarios/triso/deployment_calcs/growth_calculations.ipynb Outdated Show resolved Hide resolved
scenarios/triso/deployment_calcs/growth_calculations.ipynb Outdated Show resolved Hide resolved
Copy link
Member Author

@nsryan2 nsryan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @LukeSeifert! I've gone through and adjusted to your excellent finds, when this gets merged, I'll pull the updates to the low growth scenario in #172

scenarios/triso/README.md Outdated Show resolved Hide resolved
scenarios/triso/README.md Show resolved Hide resolved
scenarios/triso/deployment_calcs/lwr_info.csv Outdated Show resolved Hide resolved
scenarios/triso/deployment_calcs/operating_lwrs.ipynb Outdated Show resolved Hide resolved
scenarios/triso/deployment_calcs/lwr_info.csv Outdated Show resolved Hide resolved
@nsryan2 nsryan2 requested a review from LukeSeifert October 3, 2024 18:43
@nsryan2
Copy link
Member Author

nsryan2 commented Oct 3, 2024

Ok, thank you for the feedback @LukeSeifert, I have addressed each of your comments!

Copy link
Contributor

@LukeSeifert LukeSeifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@LukeSeifert LukeSeifert merged commit 34f8f41 into arfc:master Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants