Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support metamask with latest @starknet-io/get-starknet-core version #160

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

khanti42
Copy link
Contributor

@khanti42 khanti42 commented Dec 2, 2024

Issue / feature description

MetaMask is now supported on get-starknet v4 starting from version 4.0.4.

This PR updates dependencies of get-starknet and get-starknet-core to ^4.0.4.

It also adds an icon for the MetaMask wallet.

I am not sure the icon is needed because when doing :

import { connect, disconnect } from "starknetkit";
import { InjectedConnector } from "starknetkit/injected";
const { wallet } = await connect({
  connectors: [
    new InjectedConnector({
      options: { id: "metamask" },
    }),
  ],
})
Screen.Recording.2024-12-02.at.11.14.05.mov

It seems to be using the logo from get-starknet directly.

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

Please keep your pull request as small as possible. If you need to make multiple changes, please create separate pull requests for each change. Create a draft pull request if you need early feedback. This will mark the pull request as a work in progress and prevent it from being reviewed or merged until you are ready.

Please move drafts to the ready for review (regular PR) when you are ready to start the review process and other developers will pick it up from there.

@khanti42 khanti42 force-pushed the fix/add-metamask-support branch from b8c2f06 to df23e22 Compare December 2, 2024 10:09
@khanti42 khanti42 force-pushed the fix/add-metamask-support branch from df23e22 to 90b941c Compare December 2, 2024 10:10
@Cussone Cussone requested review from Cussone and bluecco December 2, 2024 12:17
@bluecco bluecco merged commit 8e77744 into argentlabs:develop Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants