Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw error from requestWallet if caught error has message prop #163

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix: throw error from requestWallet if caught error has message prop #163

merged 2 commits into from
Dec 10, 2024

Conversation

Cussone
Copy link
Member

@Cussone Cussone commented Dec 10, 2024

Issue / feature description

The connector for Argent mobile was throwing "Unknow error on requestWallet" error because the caught error is not instanceof Error.

Changes

  • Throw error if caught error has message property on it.

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

@Cussone Cussone requested review from bluecco and gergold December 10, 2024 08:34
@Cussone Cussone merged commit db55a98 into develop Dec 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluecco bluecco bluecco approved these changes

@gergold gergold Awaiting requested review from gergold

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cussone @bluecco