feat[ibmsm]: Add support for service_credentials secret type #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jarek Gawor <[email protected]>
Signed-off-by: Jarek Gawor <[email protected]>
Signed-off-by: Jarek Gawor <[email protected]>
Signed-off-by: Jarek Gawor <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
==========================================
- Coverage 72.16% 71.79% -0.38%
==========================================
Files 26 29 +3
Lines 1994 2627 +633
==========================================
+ Hits 1439 1886 +447
- Misses 458 589 +131
- Partials 97 152 +55 ☔ View full report in Codecov by Sentry. |
jkayani
approved these changes
May 17, 2024
|
@werne2j could you please take a look at this PR? thanks. |
werne2j
approved these changes
Jun 11, 2024
Signed-off-by: Jarek Gawor <[email protected]>
jgawor
force-pushed
the
ibm_secret_manager_service_creds
branch
from
fa2dad5
to
86fdaa9
Compare
|
@werne2j updated now |
|
@werne2j one more ping :) |
|
@werne2j one more ping |
|
@werne2j and one more ping. |
|
@jkayani maybe you can merge? |
|
@jgawor looks like there are conflicts. Once resolved i will merge this in. |
|
@werne2j I just updated the PR. |
|
@werne2j one more ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for
service_credentialssecret type.Checklist
Please make sure that your PR fulfills the following requirements:
go mod tidy -compat=1.21to ensure only the minimum is pulled in.Type of Change
Other information