chore: use sigs.k8s.io/yaml/goyaml.v* instead of gopkg.in/yaml.v*

[mmorel-35]

Description

gomodguard allows to block some dependencies.

This ensure than gopkg.in/yaml.v2 and gopkg.in/yaml.v3 are not used anymore as sigs.k8s.io/yaml provides them both

[bunnyshell]

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

• 🔵 /bns:start to start the environment
• 🚀 /bns:deploy to redeploy the environment
• ❌ /bns:delete to remove the environment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.23%. Comparing base (a807c0e) to head (0549978).

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #21273   +/-   ##
=======================================
  Coverage   55.22%   55.23%           
=======================================
  Files         337      337           
  Lines       56945    56945           
=======================================
+ Hits        31447    31451    +4     
+ Misses      22816    22814    -2     
+ Partials     2682     2680    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andrii-korotkov-verkada]

Hm, there are some differences in how those handle things. E.g. time.Duration for sigs yaml is expected to be integer in nanoseconds, while for regular yaml it'd be in format like "1h".

[andrii-korotkov-verkada]

Can you add a test with time duration parsing or point at the existing one, please?

[mmorel-35]

Does thoses tests fits your expectations or do you need more ?

goyaml.v3

https://github.com/kubernetes-sigs/yaml/blob/master/goyaml.v3/encode_test.go#L334-L336
https://github.com/kubernetes-sigs/yaml/blob/master/goyaml.v3/decode_test.go#L616-L619

goyaml.v2

https://github.com/kubernetes-sigs/yaml/blob/master/goyaml.v2/encode_test.go#L306-L309
https://github.com/kubernetes-sigs/yaml/blob/master/goyaml.v2/decode_test.go#L540-L543

[andrii-korotkov-verkada]

Looks like it won't accept ints in new versions as duration https://github.com/kubernetes-sigs/yaml/blob/master/goyaml.v3/decode_test.go#L926. Looks like sigs yaml version 1 is used in Argo CD now. Overall, this would be a breaking change, e.g. in my case there's already a config that specifies nanoseconds int for a duration.

I think this may be a change we want for Argo CD v3. For now, I suggest to only migrate places that use gopkg.in/yaml.*, but keep existing places that use sigs yaml v1 (if any were updated).

[mmorel-35]

This PR only moves from gopkg.in/yaml.v* to sigs.k8s.io/yaml/goyaml.v* .
So if I follow you, that's fine ?

[andrii-korotkov-verkada]

Yeah, I believe so.

[crenshaw-dev]

This one worries me. It's not clear that it makes sense in every case to use the k8s fork. iiuc, the k8s fork is for high-priority fixes for problems that affect core k8s libraries. It's possible that those bugs also affect Argo CD. But it's also possible that the k8s fork trades off things like performance in order to get those bug fixes.