Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable context-as-argument from revive #21371

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Jan 4, 2025

Description

context-as-argument: By convention, context.Context should be the first parameter of a function. This rule spots function declarations that do not follow the convention.

⚠️ This includes breaking changes for some public functions

@mmorel-35 mmorel-35 requested a review from a team as a code owner January 4, 2025 07:20
Copy link

bunnyshell bot commented Jan 4, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 71.91011% with 25 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@e66068c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cmd/argocd/commands/app.go 0.00% 10 Missing ⚠️
cmd/argocd/commands/app_actions.go 0.00% 3 Missing ⚠️
server/application/application.go 84.21% 3 Missing ⚠️
cmd/argocd/commands/project.go 0.00% 2 Missing ⚠️
server/project/project.go 71.42% 2 Missing ⚠️
server/applicationset/applicationset.go 83.33% 1 Missing ⚠️
server/cluster/cluster.go 66.66% 0 Missing and 1 partial ⚠️
util/argo/argo.go 83.33% 1 Missing ⚠️
util/grpc/logging.go 66.66% 1 Missing ⚠️
util/settings/settings.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #21371   +/-   ##
=========================================
  Coverage          ?   53.31%           
=========================================
  Files             ?      337           
  Lines             ?    57056           
  Branches          ?        0           
=========================================
  Hits              ?    30418           
  Misses            ?    23983           
  Partials          ?     2655           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 force-pushed the revive/context-as-argument branch from 5d484f4 to 944179e Compare January 5, 2025 09:58
@mmorel-35 mmorel-35 force-pushed the revive/context-as-argument branch from 944179e to 38257c8 Compare January 6, 2025 17:02
@crenshaw-dev crenshaw-dev merged commit b04a7c1 into argoproj:master Jan 7, 2025
25 checks passed
@mmorel-35 mmorel-35 deleted the revive/context-as-argument branch January 7, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants