Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): proto references bump #21391

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

crenshaw-dev
Copy link
Member

I'm not sure why putting both execs on the same line failed to update the proto lines like github.com.argoproj.argo_cd.v2.pkg.apis.application.v1alpha1.SyncStrategy. But splitting it to a new line works and is easier to read. Tested locally, looks fine.

Signed-off-by: Michael Crenshaw <[email protected]>
@crenshaw-dev crenshaw-dev requested a review from a team as a code owner January 6, 2025 18:33
Copy link

bunnyshell bot commented Jan 6, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@crenshaw-dev crenshaw-dev mentioned this pull request Jan 6, 2025
2 tasks
Copy link
Member

@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) January 6, 2025 18:56
@crenshaw-dev crenshaw-dev merged commit 43d2a3d into argoproj:master Jan 6, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants