Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CODEOWNERS #641

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Nov 18, 2024

Setting up CODEOWNERS file so people are automatically notified about new PRs. Pretty much matches argoproj/argo-cd CODEOWNERS file. Thank you @leoluz for that feedback (below).

@jmeridth
Copy link
Member Author

Mentioning the folks in my assumed CODEOWNERS explicitly to ensure they want to be added. I'm not trying to add to anyone's spam.

/cc @alexmt @crenshaw-dev @pasha-codefresh @ishitasequeira

Please advice who or what team/group could/should be in a CODEOWNERS file.

@jmeridth
Copy link
Member Author

jmeridth commented Nov 18, 2024

Also @dthomson25 user's GitHub profile, listed as reviwer in OWNERS, is very barren (zero activity). Any feedback? Kind of wondering if bot/etc and we should remove from EMERITUS.md? (@dthomson25 apologies if you're legit 😄 )

update: I mixed up GitHub usernames. Sorry @dthomson25 ❤️ . Thank you for commenting on this PR below.

@dthomson25
Copy link
Member

Also @dthomson25 user's GitHub profile, listed as reviwer in OWNERS, is very barren (zero activity). Any feedback? Kind of wondering if bot/etc and we should remove from EMERITUS.md? (@dthomson25 apologies if you're legit 😄 )

All good, and the username in the PR is (https://github.com/dthomas25) instead of mine (https://github.com/dthomson25)! I use to work at Intuit and worked full time on the Argo project until I took another job that required me to step back. I helped review a lot of the initial docs for the gitops-engine.

@jmeridth
Copy link
Member Author

Also @dthomson25 user's GitHub profile, listed as reviwer in OWNERS, is very barren (zero activity). Any feedback? Kind of wondering if bot/etc and we should remove from EMERITUS.md? (@dthomson25 apologies if you're legit 😄 )

All good, and the username in the PR is (https://github.com/dthomas25) instead of mine (https://github.com/dthomson25)! I use to work at Intuit and worked full time on the Argo project until I took another job that required me to step back. I helped review a lot of the initial docs for the gitops-engine.

🤦 @dthomson25 thank you for clarifying. My bad on getting the username incorrect. ❤️

Setting up CODEOWNERS file so people are automatically notified about new PRs. Can
eventually setup ruleset that requires at least one review before merging.

I based currently list in CODEOWNERS on people who have recently merged PRs. I'm wondering
if reviewers and approvers are a team/group instead of list of folks.

Setup EMERITUS.md that contains list from OWNERS.  Feedback on this PR will update
this PR.

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth force-pushed the jm_create_codeowners branch from 455543a to b297fed Compare November 20, 2024 01:25
@leoluz
Copy link
Contributor

leoluz commented Dec 12, 2024

@jmeridth Basically gitops-engine repo should mirror the codeowners from the Argo CD repo.
Also, there is a long running task to merge this repo in Argo CD.

@jmeridth
Copy link
Member Author

jmeridth commented Dec 12, 2024

Also, there is a long running task to merge this repo in Argo CD.

Gotcha re: CODEOWNERS. Should I change this CODEOWNERS to match it?

# All
** @argoproj/argocd-approvers

long running task. Yep. I've been hearing that for years. I'd prefer to get the repo fixed up to good standards and then start looking at the 70+ PRs. wdyt?

@jmeridth jmeridth changed the title chore: add CODEOWNERS and EMERITUS.md chore: add CODEOWNERS Dec 12, 2024
Copy link

sonarcloud bot commented Dec 12, 2024

@jmeridth jmeridth requested a review from leoluz December 12, 2024 16:37
@jmeridth
Copy link
Member Author

Discussed in 12/12/24 contributors meeting. Getting CODEOWNERS to match argoproj/argo-cd CODEOWNERS is the path forward.

@jmeridth jmeridth requested a review from a team December 12, 2024 16:48
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for working on this!
LGTM

@leoluz leoluz merged commit 363a715 into argoproj:master Dec 12, 2024
4 checks passed
@jmeridth jmeridth deleted the jm_create_codeowners branch December 12, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants