-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add CODEOWNERS #641
Conversation
Mentioning the folks in my assumed CODEOWNERS explicitly to ensure they want to be added. I'm not trying to add to anyone's spam. /cc @alexmt @crenshaw-dev @pasha-codefresh @ishitasequeira Please advice who or what team/group could/should be in a CODEOWNERS file. |
update: I mixed up GitHub usernames. Sorry @dthomson25 ❤️ . Thank you for commenting on this PR below. |
All good, and the username in the PR is (https://github.com/dthomas25) instead of mine (https://github.com/dthomson25)! I use to work at Intuit and worked full time on the Argo project until I took another job that required me to step back. I helped review a lot of the initial docs for the gitops-engine. |
🤦 @dthomson25 thank you for clarifying. My bad on getting the username incorrect. ❤️ |
Setting up CODEOWNERS file so people are automatically notified about new PRs. Can eventually setup ruleset that requires at least one review before merging. I based currently list in CODEOWNERS on people who have recently merged PRs. I'm wondering if reviewers and approvers are a team/group instead of list of folks. Setup EMERITUS.md that contains list from OWNERS. Feedback on this PR will update this PR. Signed-off-by: jmeridth <[email protected]>
455543a
to
b297fed
Compare
@jmeridth Basically |
Gotcha re: CODEOWNERS. Should I change this CODEOWNERS to match it? # All
** @argoproj/argocd-approvers
|
Signed-off-by: jmeridth <[email protected]>
Quality Gate passedIssues Measures |
Discussed in 12/12/24 contributors meeting. Getting CODEOWNERS to match argoproj/argo-cd CODEOWNERS is the path forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for working on this!
LGTM
Setting up CODEOWNERS file so people are automatically notified about new PRs. Pretty much matches argoproj/argo-cd CODEOWNERS file. Thank you @leoluz for that feedback (below).