Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self Service Configuration from Factory #207

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mayzhang2000
Copy link
Contributor

No description provided.

@mayzhang2000 mayzhang2000 force-pushed the self-service-clusterwise branch from 6ca38af to 2d42563 Compare August 7, 2023 18:00
@mayzhang2000 mayzhang2000 force-pushed the self-service-clusterwise branch 2 times, most recently from b7cf4ec to e7b7b2a Compare August 7, 2023 20:55
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.03% 🎉

Comparison is base (e3e9fda) 53.57% compared to head (976fc5a) 53.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   53.57%   53.60%   +0.03%     
==========================================
  Files          34       34              
  Lines        3091     3106      +15     
==========================================
+ Hits         1656     1665       +9     
- Misses       1188     1193       +5     
- Partials      247      248       +1     
Files Changed Coverage Δ
pkg/api/factory.go 53.65% <0.00%> (-0.89%) ⬇️
pkg/controller/controller.go 67.60% <94.73%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mayzhang2000 mayzhang2000 force-pushed the self-service-clusterwise branch from 0e4ec6e to 24fdc68 Compare August 7, 2023 22:13
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
@mayzhang2000 mayzhang2000 force-pushed the self-service-clusterwise branch from 6a04604 to 976fc5a Compare August 7, 2023 22:19
@zachaller zachaller self-requested a review August 7, 2023 22:24
@mayzhang2000 mayzhang2000 marked this pull request as draft August 8, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants