Add option for Telegram to use a thread id when posting notification #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #265 +/- ##
==========================================
+ Coverage 55.14% 55.50% +0.36%
==========================================
Files 35 35
Lines 3400 3412 +12
==========================================
+ Hits 1875 1894 +19
+ Misses 1251 1242 -9
- Partials 274 276 +2 ☔ View full report in Codecov by Sentry. |
pasha-codefresh
requested changes
Feb 7, 2024
Signed-off-by: Christiaan de Die le Clercq <[email protected]>
Signed-off-by: Christiaan de Die le Clercq <[email protected]>
kzap
added a commit
to kzap/argo-rollouts
that referenced
this pull request
Feb 20, 2024
- Update go.mod: github.com/go-telegram-bot-api/telegram-bot-api/v5 => github.com/OvyFlash/telegram-bot-api/v5 v5.0.0-20240108230938-63e5c59035bf - Ref: argoproj/notifications-engine#265 - Could also be done via go replace --edit - go mod tidy also ran Signed-off-by: Andre Marcelo-Tanner <[email protected]>
6 tasks
zachaller
pushed a commit
to argoproj/argo-rollouts
that referenced
this pull request
Feb 27, 2024
* Run: go get github.com/argoproj/notifications-engine@7a069766e95476e1074eeed6145085160e2fec63 Updating and fetch latest notifications-engine dependencies Signed-off-by: Andre Marcelo-Tanner <[email protected]> * Run: go get github.com/argoproj/notifications-engine/pkg/[email protected] Signed-off-by: Andre Marcelo-Tanner <[email protected]> * Replace telegram-bot-api and run go mod tidy - Update go.mod: github.com/go-telegram-bot-api/telegram-bot-api/v5 => github.com/OvyFlash/telegram-bot-api/v5 v5.0.0-20240108230938-63e5c59035bf - Ref: argoproj/notifications-engine#265 - Could also be done via go replace --edit - go mod tidy also ran Signed-off-by: Andre Marcelo-Tanner <[email protected]> * Add strReplaceDocFiles to update strings from default docs Signed-off-by: Andre Marcelo-Tanner <[email protected]> * Run: make docs Signed-off-by: Andre Marcelo-Tanner <[email protected]> * replace <config-map-name> with argo-rollouts-notification-configmap and also replace secret with argocd-notifications-secret Signed-off-by: Andre Marcelo-Tanner <[email protected]> * add Ada company to USERS.md Signed-off-by: Andre Marcelo-Tanner <[email protected]> * chore: update contributing docs with notifications engine section Signed-off-by: Andre Marcelo-Tanner <[email protected]> --------- Signed-off-by: Andre Marcelo-Tanner <[email protected]>
14 tasks
ParjadM
pushed a commit
to ParjadM/ArgoRollOut
that referenced
this pull request
Dec 8, 2024
* Run: go get github.com/argoproj/notifications-engine@7a069766e95476e1074eeed6145085160e2fec63 Updating and fetch latest notifications-engine dependencies Signed-off-by: Andre Marcelo-Tanner <[email protected]> * Run: go get github.com/argoproj/notifications-engine/pkg/[email protected] Signed-off-by: Andre Marcelo-Tanner <[email protected]> * Replace telegram-bot-api and run go mod tidy - Update go.mod: github.com/go-telegram-bot-api/telegram-bot-api/v5 => github.com/OvyFlash/telegram-bot-api/v5 v5.0.0-20240108230938-63e5c59035bf - Ref: argoproj/notifications-engine#265 - Could also be done via go replace --edit - go mod tidy also ran Signed-off-by: Andre Marcelo-Tanner <[email protected]> * Add strReplaceDocFiles to update strings from default docs Signed-off-by: Andre Marcelo-Tanner <[email protected]> * Run: make docs Signed-off-by: Andre Marcelo-Tanner <[email protected]> * replace <config-map-name> with argo-rollouts-notification-configmap and also replace secret with argocd-notifications-secret Signed-off-by: Andre Marcelo-Tanner <[email protected]> * add Ada company to USERS.md Signed-off-by: Andre Marcelo-Tanner <[email protected]> * chore: update contributing docs with notifications engine section Signed-off-by: Andre Marcelo-Tanner <[email protected]> --------- Signed-off-by: Andre Marcelo-Tanner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also migrates the go library to the one from OvyFlash, since the current one seems to be no longer maintained:
go-telegram-bot-api/telegram-bot-api#695