feat: allow granular selection of GitHub notification method via destination #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tony Li <[email protected]>
Signed-off-by: Tony Li <[email protected]>
tonglil
force-pushed
the
granular-github-notifications
branch
from
fb88628 to
a7a1cee
Compare
pasha-codefresh
requested changes
Jun 10, 2024
pkg/services/github.go
Outdated
| sendComment bool | ||
| ) | ||
|
|
||
| switch dest.Recipient { |
There was a problem hiding this comment.
i would suggest instead create variables, split them into different functions and execute inside switch
There was a problem hiding this comment.
Updated. Couldn't use switch without making it very complex.
Signed-off-by: Tony Li <[email protected]>
Signed-off-by: Tony Li <[email protected]>
tonglil
force-pushed
the
granular-github-notifications
branch
from
d34faba to
56a3811
Compare
tonglil
changed the title
tonglil
changed the title
|
Ping @pasha-codefresh or any other owner? |
|
Will review. Sorry for delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if someone has all of the GH notification types configured, subscribing to it will update all of them without a way to choose which one.
This is useful when you want to use commit status for one type of trigger, and deployments for another.
The change retains the existing behavior: if no recipient is specified in the subscription annotation, all notification types will be updated.