Update Github integration instructions #306
Conversation
|
@Amphaal please fix DCO check |
|
@CodiumAI-Agent /review |
PR Reviewer Guide 🔍(Review updated until commit 9d9e735)Here are some key observations to aid the review process:
|
| template.app-deployed: | | ||
| message: | | ||
| Application {{.app.metadata.name}} is now running new version of deployments manifests. | ||
| github: | ||
| repoURLPath: "{{.app.spec.source.repoURL}}" | ||
| revisionPath: "{{.app.status.operationState.syncResult.revision}}" | ||
| revisionPath: "{{.app.status.operationState.operation.sync.revision}}" |
There was a problem hiding this comment.
why would you take it from operation instead syncResult?
There was a problem hiding this comment.
Because it did not work otherwise with my setup, and I could not tell why ! In my Application manifests, syncResult was missing for some reasons. I double checked this time and I can now find it. What is the difference between both ? Why would this happen ?
There was a problem hiding this comment.
syncResult exist when sync already finished. It may not exist if application is just created and sync still didnt happen before
|
Persistent review updated to latest commit 9d9e735 |
following up argoproj/argo-cd#18546 (comment) instructions