Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate spellchecker #40

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

tmkx
Copy link

@tmkx tmkx commented Sep 25, 2024

issue track: #39

  • comment
  • struct/enum/service/exception name
  • struct/enum/service/exception member
  • unit test

@tmkx tmkx force-pushed the feat/spellcheck branch 2 times, most recently from 1932788 to 61074db Compare September 28, 2024 16:21
@tmkx tmkx requested a review from arhont375 September 28, 2024 16:52
@tmkx tmkx force-pushed the feat/spellcheck branch 3 times, most recently from 0a59a61 to edd80b3 Compare October 1, 2024 01:14
@@ -0,0 +1,20 @@
struct <TYPO>Userr</TYPO> {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this file to the resources/inspections/spell

@arhont375
Copy link
Owner

Also may I ask you to add following dependency:

    // See: https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-faq.html#missing-opentest4j-dependency-in-test-framework
    testImplementation("org.opentest4j:opentest4j:1.3.0")

Somewhere around here

implementation("org.awaitility:awaitility:4.2.1")

This will help with class not found exception when your test cases fail.
And after that I believe it would be good to go

@tmkx tmkx force-pushed the feat/spellcheck branch from edd80b3 to be1e0be Compare October 1, 2024 12:27
@tmkx
Copy link
Author

tmkx commented Oct 1, 2024

all done :)

@arhont375
Copy link
Owner

Thanks a lot for your contribution, it will take 1-2 days before new version would be available for download

@arhont375 arhont375 merged commit 8c3373a into arhont375:develop Oct 1, 2024
2 checks passed
@tmkx tmkx deleted the feat/spellcheck branch October 1, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants