fix(execute): use fresh context for post-run hooks #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that command post-run hooks receive a fresh context instead of the original context passed to the `Execute` functions. This is needed since often the context passed to the `Execute` functions is canceled by the time the post-run hooks are ran - either by the OS signal, deadlines, or other reasons.
arikkfir
force-pushed
the
arikkfir/use-fresh-context-for-post-hooks
branch
from
dd17876
to
1a9d807
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that command post-run hooks receive a fresh context instead of the original context passed to the
Executefunctions.This is needed since often the context passed to the
Executefunctions is canceled by the time the post-run hooks are ran - either by the OS signal, deadlines, or other reasons.