Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case when the oinstall group already exist on the network #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MichaelPereira
Copy link
Contributor

Hi Ari,

I ran into this problem while installing the oracle client on our machine as the group oinstall is already created on the network. With this change, we can avoid the error that chef will throw when trying to create an existing group.

The oracli_user_config.rb will also try to create as it is a default group in node[:oracle][:cliuser][:sup_grps] but this can be disabled by removing it from the default attributes or overriding it at the node/role level.

Let me know if you have any comments or questions

@aririikonen
Copy link
Owner

aririikonen commented Jul 22, 2016

Michael,

Thank you for your pull request. How about, if we just add an not_if to the resource, like this.

not_if "grep ^oinstall /etc/group"

Would that work?

@MichaelPereira
Copy link
Contributor Author

You're right, it's a simple way that avoid adding one more attribute. I will change the code and update the PR this week-end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants