Enhancements and a Bugfix #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 9, 2016 15:40
|
mrmarbury, Thank you for your pull request. I need to run some tests against the current code base. This might take some time. |
|
allright, no problem. I will create some more pull requests over time. I am currently customizing this CB quite a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some formatting stuff which is pretty trivial. Just spaces mostly.
The BugFix: When installing the client, The rsp file is placed into install_dir but needed in ora_home. I changed it to ora_home to make it equivalent to "latest_dbpatch.rb".
The Enhancement: Making extra components for EE selectable.
If you merge this it would be cool to have the new version with these changes in the supermarket soon. We are currently using a forked version of your CB and we would rather use the Master.
Cheers,
Stef