Refactor(eos_designs): Use python classes built from schemas for inputs #4603
+153,297
−10,189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4603
# Activate the virtual environment
source test-avd-pr-4603/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@schemas-as-classes-no-validation-nested#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,schemas-as-classes-no-validation-nested --force
# Optional: Install AVD examples
cd test-avd-pr-4603
ansible-playbook arista.avd.install_examples |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ClausHolbechArista
force-pushed
the
schemas-as-classes-no-validation-nested
branch
from
2ca3b9b
to
bfeca85
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
force-pushed
the
schemas-as-classes-no-validation-nested
branch
from
b103dd9
to
032572f
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
force-pushed
the
schemas-as-classes-no-validation-nested
branch
from
6de1bee
to
e101cc8
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ClausHolbechArista
force-pushed
the
schemas-as-classes-no-validation-nested
branch
from
15b7c65
to
c0188b3
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
added
state: conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
gmuloc
reviewed
Oct 31, 2024
for more information, see https://pre-commit.ci
ClausHolbechArista
force-pushed
the
schemas-as-classes-no-validation-nested
branch
from
b10d1d6
to
346fe60
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add python classes built from schemas
Component(s) name
arista.avd.eos_designsProposed changes
eos_designsplugins and classes to load inputs into anEosDesignsclass instance.EosDesignsclass.How to test
No changes to molecule.
Checklist
User Checklist
Repository Checklist