-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_cli_config_gen): Improve the aaa accounting j2 template #4636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
state: CI Updated
CI scenario have been updated in the PR
label
Oct 23, 2024
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4636
# Activate the virtual environment
source test-avd-pr-4636/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4630#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4630 --force
# Optional: Install AVD examples
cd test-avd-pr-4636
ansible-playbook arista.avd.install_examples |
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/aaa.cfg
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/aaa.cfg
Outdated
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
requested changes
Nov 6, 2024
...lections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/aaa-accounting.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/aaa-accounting.j2
Outdated
Show resolved
Hide resolved
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: Documentation role Updated
labels
Nov 7, 2024
Quality Gate passedIssues Measures |
ClausHolbechArista
previously requested changes
Nov 8, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/aaa_accounting.schema.yml
Outdated
Show resolved
Hide resolved
Moving to draft until comments have been addressed |
github-actions
bot
removed
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: Documentation role Updated
labels
Nov 22, 2024
gmuloc
reviewed
Nov 28, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/aaa_accounting.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/aaa_accounting.schema.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/aaa-accounting.j2
Outdated
Show resolved
Hide resolved
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: Documentation role Updated
labels
Nov 29, 2024
laxmikantchintakindi
approved these changes
Dec 2, 2024
gmuloc
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Refactor(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Improve the aaa accounting j2 template.
Related Issue(s)
Fixes #4630
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
How to test
Run molecule with different type of inputs in aaa_accounting
Checklist
User Checklist
Repository Checklist