Skip to content

Commit

Permalink
fix: remove excess env
Browse files Browse the repository at this point in the history
  • Loading branch information
armanokka committed Jul 1, 2024
1 parent 9e609a0 commit f16a0b4
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .env.dev
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
OTLP_GRPC_RECEIVER_DSN="otel-collector:4317"
LOG_LEVEL="debug"
PORT=80

REDIS_PASSWORD=password
REDIS_PORT=6379
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ on:
pull_request:
permissions:
contents: read
# Optional: allow read access to pull request. Use with `only-new-issues` option.
# pull-requests: read
jobs:
lint-go:
runs-on: ubuntu-latest
Expand Down
5 changes: 2 additions & 3 deletions config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ import (

type Config struct {
/* Compulsory envs */
OTLPGRPCReceiverDSN string `yaml:"OTLP_GRPC_RECEIVER_DSN" env:"OTLP_GRPC_RECEIVER_DSN" env-required:"true"`
RedisPassword string `yaml:"REDIS_PASSWORD" env:"REDIS_PASSWORD" env-required:"true"`
RedisPort int `yaml:"REDIS_PORT" env:"REDIS_PORT" env-required:"true"`
RedisPassword string `yaml:"REDIS_PASSWORD" env:"REDIS_PASSWORD" env-required:"true"`
RedisPort int `yaml:"REDIS_PORT" env:"REDIS_PORT" env-required:"true"`

// Optional envs
Port int `yaml:"PORT" env:"PORT" env-default:"80"`
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ services:
- "16686:16686"
- "4317:4317"
- "4318:4318"
- "14250"
- "14250:14250"
environment:
- COLLECTOR_OTLP_ENABLED=true
deploy:
Expand Down
2 changes: 1 addition & 1 deletion internal/app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func Run(cfg *config.Config) error {
}

// Creating tracer
shutdownTracerProvider, err := initProvider(ctx, cfg.OTLPGRPCReceiverDSN)
shutdownTracerProvider, err := initProvider(ctx, "otel-collector:4317")
if err != nil {
return err
}
Expand Down

0 comments on commit f16a0b4

Please sign in to comment.