Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for specifying a custom mapper implementation for a DeployableContainer. #553

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Add support for specifying a custom mapper implementation for a DeployableContainer. #553

merged 2 commits into from
Jun 25, 2024

Conversation

starksm64
Copy link
Member

@starksm64 starksm64 commented Jun 15, 2024 •
edited
Loading

…
Fixes #552

Short description of what this resolves:

This addresses #552

Changes proposed in this pull request:

  • Add a new ConfigurationMapper interface that is returned from DeployableContainer
  • Improve the ContainerConfiguration generic type usage to avoid casts
  • Add test showing mapping of String property def to String[] in a CustomContainerConfiguration

@starksm64 starksm64 requested a review from jasondlee June 15, 2024 18:31
jamezp
jamezp approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I think this is a great idea.

@starksm64 starksm64 merged commit 9e80313 into arquillian:master Jun 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamezp jamezp jamezp approved these changes

@jasondlee jasondlee Awaiting requested review from jasondlee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@starksm64 @jamezp